New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabelledData.map drops None values returned by map function #1685

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jul 6, 2017

Discussion about why this fix is needed in #1681

@philippjfr philippjfr added the bug label Jul 6, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 6, 2017

Tests have passed and I am happy to merge. That said, if map is discussed anywhere in the user guide atm this particular behavior should be mentioned...

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jul 6, 2017

I think we meant to mention it in the nesting data user guide but haven't done so far.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 6, 2017

Please open a docs issue as a reminder to do that.

@jlstevens jlstevens merged commit 0c057fb into master Jul 6, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on map_drops_nones at 79.672%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the map_drops_nones branch Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment