Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTML holomap export to notebook archive #2480

Closed
wants to merge 3 commits into from

Conversation

jlstevens
Copy link
Contributor

This WIP PR is attempting to address #449.

Unfortunately, it isn't working yet as bokeh JS isn't included in the output. I see various issues:

  • I think __call__ should simply be the data saved to file by save.
  • The __call__ method should not be used internally e.g in the html method.

By making __call__ closely related to save, users using __call__ will get useful, self-contained output which is currently not the case.

If we fix those issues, I'll have to think about whether the changes I've currently made to the renderers needs to stick or go away.

@philippjfr
Copy link
Member

Closing, will try to fix this in #3836

@philippjfr philippjfr closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants