Adding HTML holomap export to notebook archive #2480
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR is attempting to address #449.
Unfortunately, it isn't working yet as bokeh JS isn't included in the output. I see various issues:
__call__
should simply be the data saved to file bysave
.__call__
method should not be used internally e.g in thehtml
method.By making
__call__
closely related tosave
, users using__call__
will get useful, self-contained output which is currently not the case.If we fix those issues, I'll have to think about whether the changes I've currently made to the renderers needs to stick or go away.