New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changes to columns in bokeh CDS #2666
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
af9248e
Added support for changing columns in CDS
philippjfr 5fe5fc3
Added support for updating Table columns
philippjfr f11eb9b
Added netcdftime to travis environment
philippjfr ebee571
Added unit tests for column updates
philippjfr 95383b8
Pinned netcdf4
philippjfr fa5560b
Simplified CDS update logic
philippjfr File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -225,6 +225,18 @@ def _update_datasource(self, source, data): | |
source.data.update(converted_data) | ||
else: | ||
source.stream(data, stream.length) | ||
return | ||
|
||
# Determine if the CDS.data requires a full update or simply needs | ||
# to be updated, this is done by determining whether newly added | ||
# or not updated columns have the same length | ||
new_length = [len(v) for v in data.values() if isinstance(v, (list, np.ndarray))] | ||
length = [len(v) for v in source.data.values() if isinstance(v, (list, np.ndarray))] | ||
not_updated = [k for k in source.data if k not in data] | ||
new = [k for k in data if k not in source.data] | ||
if ((not_updated and new_length and any(len(source.data[n]) != new_length[0] for n in not_updated)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure you need the initial There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that is also true for the check against |
||
or (new and length and any(len(data[n]) != length[0] for n in new))): | ||
source.data = data | ||
else: | ||
source.data.update(data) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR but apparently required to get tests passing again.