Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in Point size handling? #466

Closed
jbednar opened this issue Feb 7, 2016 · 6 comments
Closed

Change in Point size handling? #466

jbednar opened this issue Feb 7, 2016 · 6 comments
Milestone

Comments

@jbednar
Copy link
Member

jbednar commented Feb 7, 2016

Didn't this previously have fixed-sized dots?

image

@jbednar
Copy link
Member Author

jbednar commented Feb 7, 2016

And I know this one did:

image

@philippjfr
Copy link
Member

Yes it's changed because the point scaling behavior has changed. Previously size_index was set to 3 but the scaling_factor was set to 1 and point scaling was only enabled if scaling_factor>1. The recent changes meant that the scaling_factor is actually a scaling factor and has no effect on whether or not the points get scaled by size. So there is no equivalent option, my choices were either to set size_index to None so it would have to be explicitly activated everywhere or to leave it as is and have some plots (like the ones above) change to use point scaling.

@jbednar
Copy link
Member Author

jbednar commented Feb 8, 2016

Ok. Can you fix these examples in the tutorial to make them work like they did before, then clarify here what users need to do to get the old behavior back in their own code? Then the release notes for 1.4.2 can link back to this issue, saying that the default behavior for point sizing has changed and that user code may need updating.

@jbednar
Copy link
Member Author

jbednar commented Feb 8, 2016

(Not that I'm saying that the old behavior was better, just that if people have code that relied on it, as here, it's important to be able to make it work the same again.)

@philippjfr
Copy link
Member

Okay I fixed the examples in #472. To disable the size being used simply set size_index=None. Will close this issue and add a reference to it from the CHANGELOG.

@jbednar
Copy link
Member Author

jbednar commented Feb 8, 2016

Looks good; thanks so much!

@philippjfr philippjfr added this to the 1.4.3 milestone Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants