Implemented slicing semantics for bounded DynamicMaps #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work fine in the examples I've tried. If it looks ok to you, could you please merge? |
| (start, stop) = slc.start, slc.stop | ||
| if start and start < cloned.kdims[i].range[0]: | ||
| raise Exception("Requested slice below defined dimension range.") | ||
| if stop and stop > cloned.kdims[i].range[1]: |
There was a problem hiding this comment.
Make sure you check start is not None and stop is not None explicitly otherwise it'll fall through for zeros.
There was a problem hiding this comment.
Good point. Fixed in the last commit.
|
Made one comment, looks fine otherwise. |
|
Looks good, will merge as soon as tests pass. |
philippjfr
added a commit
that referenced
this pull request
Feb 10, 2016
Implemented slicing semantics for bounded DynamicMaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you start using slices in bounded mode, you have to use slices throughout.
Slicing sets/unsets the dimension soft_ranges which can be used to restrict the explorable region. I'll be documenting this in the new Dynamic Map tutorial.