Made color handling for all matplotlib plots consistent #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
Looks good. Removing redundant parameter definitions is always a good thing! |
philippjfr
force-pushed
the
symmetric_fix
branch
from
2718e21
to
41ff7ea
Compare
|
Agreed, although it was also an actual bug because some classes didn't have the parameter so it could fail in some cases. I've expanded the scope of the PR a little bit by consistently using the ColorbarPlot method to set color ranges so they all now support logarithmic and symmetric color ranges. |
philippjfr
changed the title
philippjfr
force-pushed
the
symmetric_fix
branch
2 times, most recently
from
6287d1a
to
b2cb873
Compare
philippjfr
force-pushed
the
symmetric_fix
branch
from
b2cb873
to
286299c
Compare
|
Tests are passing and I confirmed the options actually work on the different plot types. Ready to merge. |
|
Great! |
jlstevens
added a commit
that referenced
this pull request
Feb 18, 2016
Made color handling for all matplotlib plots consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for ColorbarPlots, moving
symmetricplot option to the base class where it is used.