Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various plotting fixes #532

Merged
merged 9 commits into from Mar 4, 2016
Merged

Various plotting fixes #532

merged 9 commits into from Mar 4, 2016

Conversation

philippjfr
Copy link
Member

A number of fixes to plotting in particular for the bokeh backend.

The fixes include:

  • Empty datasources cause issues in 0.11.1, now setting the glyph invisible instead
  • Datetime axes limits were being inferred incorrectly on OverlayPlots
  • Fixed some outdated method signatures and unreferenced variables
  • Fixed a bug with selection_specs in Columns.select that caused issues in plotting
  • Fixed a bug in widget templating resulting in a unicode string with the u prefix being templated (causing JS syntax errors)

@jlstevens
Copy link
Contributor

I've had a look through and all the fixes look good. Thankfully this is more a collection of small, localized fixes than a refactor! If it is ready, I'm happy to merge once the tests pass.

@philippjfr philippjfr added this to the 1.4.4 milestone Mar 4, 2016
@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh tag: component: plotting labels Mar 4, 2016
@philippjfr
Copy link
Member Author

As you say just a bunch of small changes and tests are passing. Ready to merge.

@jlstevens
Copy link
Contributor

Merged.

jlstevens added a commit that referenced this pull request Mar 4, 2016
@jlstevens jlstevens merged commit ca5db7d into master Mar 4, 2016
@philippjfr philippjfr deleted the bokeh_fixes branch April 1, 2016 14:27
@philippjfr philippjfr modified the milestones: v1.5.0, 1.4.4 Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: backend: bokeh tag: component: plotting type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants