Open Dynamic and Scrubber fixes #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
scrubber_fixes
branch
from
1827013
to
9fc528b
Compare
|
Ready to merge once tests are passing. |
|
Ok the tests are passing and the fixes look good. Merging. |
jlstevens
added a commit
that referenced
this pull request
Mar 14, 2016
Open mode fixes for DynamicMap and the scrubber widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes various bugs when in DynamicMap
openmode, ensuring that events stop when the cell is deleted and ensuring that the correct frame is accessed when individual callbacks fail and when frames are dropped out of the cache. Also allows non-integerfpsvalues for widgets for infrequent polling.