Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of the custom annotations showing in VariantInspectCard should be the order that appears in the dialog for selected the annotations #1025

Closed
tonydisera opened this issue Oct 22, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@tonydisera
Copy link
Collaborator

The annotations appear in the order in which the checkboxes are checked. This is confusing because the user would expect the annotations to appear in the same order as the checkboxes appear in the dialog to select them.

Also, the order that the 'Variant Annotations' and 'Genotype Annotations' checkboxes appear seems to be the order of the variant header 'INFO' records. For 'Genotype Annotations' this is probably okay since these are a fixed order. But for the 'Variant Annotations' (from the INFO field in the vcf record), the ordering seems a bit more random — many of the fields appear in alphabetical order, but not all of the fields. For example, in the demo dataset, the INFO field 'culprit' is followed by an uppercase 'OLD_MULTIALLELIC'. So it is better to order these alphabetically, case sensitive.

@tonydisera tonydisera added this to the 4.10 milestone Oct 22, 2023
@tonydisera tonydisera modified the milestones: 4.10, 4.9 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants