Added option to save username instead of first name #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Hide the entire polling interval row if "Servermode" is selected - not only the input field. 2. Added option to choose if the adapter should save the "public username" or the first name of authenticated users.
Added option to choose if the adapter should save the "public username" or the first name of authenticated users.
(Save username instead of first name)
|
Thank you again for the effort! It works for me as well however I have to do another change in the settings page in order to "save and close" clicking the check button for that option alone wont allow me to save. Edit: After doing that once now checking/unchecking the box for the option allows me to save the settings. |
|
That is because if you update manual via github URL the new option is not saved / existing "behind the scenes" yet when you open the configuration dialog. |
|
Also mentioned here: https://forum.iobroker.net/viewtopic.php?p=138869#p138869 |
I think this is more clearly. Regarding iobroker-community-adapters#47 https://forum.iobroker.net/viewtopic.php?f=22&p=138872#p138869
BuZZy1337
added a commit
to BuZZy1337/ioBroker.telegram
that referenced
this pull request
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when you have multiple users with the same first name authenticated to the bot.
Telegram Username has to be set in the telegram app and is unique.
If the new option is enabled in the adapter settings and the user did not choose an username in the app, then the adapter will continue to use the first name of the user and send an adapter.log.warn that the user did not set an username in the app.
Already tested on my system. 😄