We now no longer rename interfaces in the jail

Some tools (Plex) filter interfaces starting with v assuming they are all VMWare interfaces. Let's stick to FreeBSD convention for our interface naming inside the jail.

Closes #470

iocage/lib/ioc_start.py

@@ -487,14 +487,21 @@ def start_network_interface_vnet(self, nic_defs, net_configs, jid):
                         continue
 
                     for addr in addrs.split(','):
-                        iface, ip = addr.split("|")
+                        try:
+                            iface, ip = addr.split("|")
+                        except ValueError:
+                            # vnet0 is now for legacy compat as we don't rename
+                            # the interface inside the jail.
+
+                            iface, ip = "vnet0", addr
 
                         if iface not in nics:
                             continue
 
                         if iface not in ifaces:
-                            self.start_network_vnet_iface(nic, bridge,
-                                                          membermtu, jid)
+                            iface = self.start_network_vnet_iface(nic, bridge,
+                                                                  membermtu,
+                                                                  jid)
 
                             ifaces.append(iface)
 
@@ -540,12 +547,11 @@ def start_network_vnet_iface(self, nic, bridge, mtu, jid):
                                               stderr=su.STDOUT)
             iocage.lib.ioc_common.checkoutput(
                 ["setfib", self.exec_fib, "jexec", f"ioc-{self.uuid}",
-                 "ifconfig", epair_b, "name", nic, "mtu", mtu],
-                stderr=su.STDOUT)
+                 "ifconfig", epair_b, "mtu", mtu], stderr=su.STDOUT)
             iocage.lib.ioc_common.checkoutput(
                 ["setfib", self.exec_fib, "jexec", f"ioc-{self.uuid}",
 
-                 "ifconfig", nic, "link", mac_b], stderr=su.STDOUT)
+                 "ifconfig", epair_b, "link", mac_b], stderr=su.STDOUT)
             iocage.lib.ioc_common.checkoutput(
                 ["ifconfig", bridge, "addm", f"{nic}:{jid}", "up"],
                 stderr=su.STDOUT)
@@ -555,7 +561,7 @@ def start_network_vnet_iface(self, nic, bridge, mtu, jid):
         except su.CalledProcessError as err:
             return f"{err.output.decode('utf-8')}".rstrip()
         else:
-            return
+            return epair_b
 
     def start_network_vnet_addr(self, iface, ip, defaultgw, ipv6=False):
         """