Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow attaching files to a trial notebook #2680

Closed
wlach opened this issue Feb 11, 2020 · 1 comment · Fixed by #2727
Closed

Allow attaching files to a trial notebook #2680

wlach opened this issue Feb 11, 2020 · 1 comment · Fixed by #2727
Assignees
@wlach

Comments

@wlach
Copy link
Contributor

wlach commented Feb 11, 2020

For the purposes of experimentation, it would be nice to allow users to attach/use files with a trial notebook. Obviously we can't actually add the files to the notebook, since we don't have permissions to do so, but we could probably fake it by adding a cached copy of the files and then uploading them if/when the user logs in and saves the notebook.

Off the top of my head, I think this would have several parts:

  • keeping an optional data structure in the redux store of "unuploaded files" (with virtual urls + content)
  • adding a user interface element to the files dialog to add these files (and displaying them if they are present)
  • modifying the fetch cell to retrieve the contents from the data structure if they are unuploaded
@wlach wlach mentioned this issue Feb 11, 2020
Closed
@wlach wlach self-assigned this Mar 3, 2020
@wlach
Copy link
Contributor Author

wlach commented Mar 3, 2020

I have begun working on this.

@wlach wlach mentioned this issue Mar 6, 2020
Merged
3 tasks
wlach added a commit to wlach/iodide that referenced this issue Apr 24, 2020
@wlach
Allow not logged in users to interact with temporary files
f7d117b 
* Allow specifying temporary files via tryit notebooks. For example:
  `tryit?iomd=1234&file=abcd&filename=abcd.txt`
* Allow uploading files when not logged in (they will be stored
  in memory and uploaded if the user ever authenticates / logs in) -
  fixes iodide-project#2680
* As part of this work, refactor files modal to use redux
wlach added a commit to wlach/iodide that referenced this issue Apr 24, 2020
@wlach
Allow not logged in users to interact with temporary files
8e855e1 
* Allow specifying temporary files via tryit notebooks. For example:
  `tryit?iomd=1234&file=abcd&filename=abcd.txt`
* Allow uploading files when not logged in (they will be stored
  in memory and uploaded if the user ever authenticates / logs in) -
  fixes iodide-project#2680
* As part of this work, refactor files modal to use redux
wlach added a commit that referenced this issue Apr 26, 2020
@wlach
Allow not logged in users to interact with temporary files (#2727)
2cba3a5 
* Allow specifying temporary files via tryit notebooks. For example:
  `tryit?iomd=1234&file=abcd&filename=abcd.txt`
* Allow uploading files when not logged in (they will be stored
  in memory and uploaded if the user ever authenticates / logs in) -
  fixes #2680
* As part of this work, refactor files modal to use redux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlach wlach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporary files + files in template strings wlach/iodide
1 participant
@wlach