Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload on login/logout on server pages (fixes #960) #1036

Merged
merged 3 commits into from
Oct 10, 2018
Merged

Reload on login/logout on server pages (fixes #960) #1036

merged 3 commits into from
Oct 10, 2018

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Oct 9, 2018

No description provided.

@wlach wlach requested a review from hamilton October 9, 2018 20:08
hamilton
hamilton suggested changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@hamilton hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two eslint errors that will need to get fixed first, but sidestepping that, this looks good to me. Once those are fixed feel free to merge at your convenience @wlach. 🎉

@hamilton hamilton merged commit d688299 into iodide-project:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamilton hamilton hamilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wlach @hamilton