Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of new or tryit notebook from iomd template #2676

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Feb 10, 2020

Partially fixes #2565, currently this is limited to creating a notebook with a specific iomd-- ideally we would also allow attaching files to the payload as well, but that will require handling these as POST requests (which is considerably more technically involved)

This also needs tests and documentation.

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

@wlach wlach temporarily deployed to iodide-staging February 10, 2020 23:16 Inactive
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #2676 into master will decrease coverage by 7.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2676      +/-   ##
=========================================
- Coverage   75.64%   68.2%   -7.44%     
=========================================
  Files         234     181      -53     
  Lines        5819    4105    -1714     
  Branches      943     824     -119     
=========================================
- Hits         4402    2800    -1602     
+ Misses       1400    1305      -95     
+ Partials       17       0      -17
Impacted Files Coverage Δ
server/openidc/tests/test_middleware.py
server/notebooks/urls.py
server/files/api_views.py
server/tests/test_settings.py
server/tests/test_token_authentication.py
server/notebooks/apps.py
server/files/serializers.py
server/notebooks/api_views.py
server/notebooks/api_urls.py
server/notebooks/middleware.py
... and 41 more

@wlach wlach marked this pull request as ready for review February 11, 2020 22:03
@wlach
Copy link
Contributor Author

wlach commented Feb 11, 2020

Added tests and changelog, I think I'm going to skip documentation of this feature for now.

@wlach wlach force-pushed the new-or-tryit-notebook-from-template branch from f103ed6 to ace6c53 Compare February 11, 2020 22:54
@wlach wlach merged commit f80cdcf into master Feb 11, 2020
@wlach wlach deleted the new-or-tryit-notebook-from-template branch February 11, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a simplified way of creating notebooks with no authentication credentials
1 participant