Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: HTTP2 #4

Closed
jonathanong opened this issue Nov 28, 2014 · 57 comments
Closed

Feature Request: HTTP2 #4

jonathanong opened this issue Nov 28, 2014 · 57 comments
Labels
discuss Issues opened for discussions and feedbacks. http Issues or PRs related to the http subsystem.

Comments

@jonathanong
Copy link
Contributor

@indutny has done great work with https://github.com/indutny/node-spdy. would love to see this added and released soon after the specs are finalized :D

@yorkie
Copy link
Contributor

yorkie commented Nov 28, 2014

+1 for http2, that would be awesome.

@haoxins
Copy link

haoxins commented Nov 28, 2014

+1

1 similar comment
@yosuke-furukawa
Copy link
Member

+1

@nmn
Copy link

nmn commented Nov 28, 2014

+1, but would also add a word of caution. That HTTP2 standard isn't quite finalized, and till that time, it makes sense for node-spdy to be the canonical way to add SPDY support.

@mikeal
Copy link
Contributor

mikeal commented Nov 28, 2014

what exactly is this feature request for? is it for http2 support to be added to core or just for an work necessary for better support in userland to be added to core (I'm not sure what that would be).

@alwayrun
Copy link

+1

@yorkie
Copy link
Contributor

yorkie commented Nov 28, 2014

I'm guessing @jonathanong is going to refer this forward project koajs/koala and here is a discussion about http2 and spdy.

@nmn
Copy link

nmn commented Nov 28, 2014

I think he's asking for http2 support in core.

Again, I think that's a great idea, but the time is not right yet.

@jonathanong
Copy link
Contributor Author

yeah this is for core support, though developing it as a userland module until all the committers agree on the implementation would be okay with me too.

@mafintosh
Copy link
Member

whats the benefit of adding this to core instead of just having it live in userland?

@nmn
Copy link

nmn commented Nov 29, 2014

I think eventually this should land in core. Node.js was ahead of the curve with it's core http module using http 1.1 when it came out. Once http2 standard is stable, support should ideally be added to core.

I think this is a low-level, fundamental feature that deserves to be in Core.

@defunctzombie
Copy link
Contributor

Not a core issue IMO. A distribution issue.

@nmn
Copy link

nmn commented Nov 29, 2014

Probably a little early to discuss this at all I guess. I think when the time comes, the best approach will feel obvious.

@liveinjs
Copy link
Contributor

liveinjs commented Dec 2, 2014

+1

1 similar comment
@dconnolly
Copy link

+1

@defunctzombie
Copy link
Contributor

Just make a module.

@ghostbar
Copy link
Contributor

ghostbar commented Dec 3, 2014

Can't see a win on making it part of core.

@ilanbiala
Copy link

HTTP should definitely not be a module, because that's one of the main features of core. That's what makes it so easy to put together a node app, and it's an advantage node has compared to other languages that separate it into a module.

@rlidwka
Copy link
Contributor

rlidwka commented Dec 22, 2014

HTTP should definitely not be a module, because that's one of the main features of core.

This "main feature" in node.js is useless. For example, I never directly use neither server (I prefer express module) nor client (I use request).

Of course we need a stable and well-maintained HTTP and HTTP2 implementations, but I don't see why it should be in core.

@ilanbiala
Copy link

If it's not in core, it should still be completely controlled by io.js, which is the same as being in core in my opinion.

@algesten
Copy link

@vkurchatkin vkurchatkin added the http Issues or PRs related to the http subsystem. label Jan 23, 2015
@Fishrock123
Copy link
Member

Support for this will be inherently necessary in the future.

HTTP/2 is landing in chrome 40 soon: http://blog.chromium.org/2015/02/hello-http2-goodbye-spdy-http-is_9.html

(+1)

@indutny
Copy link
Member

indutny commented Feb 9, 2015

Ok, +1 from me. I'll start working on it after we'll figure out #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

No branches or pull requests