Runtime attribute class resolution #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikes
force-pushed
the
runtime-attribute-class-resolution
branch
from
0a5d7b0
to
1055003
Compare
A5308Y
reviewed
Dec 17, 2021
eikes
force-pushed
the
runtime-attribute-class-resolution
branch
from
1055003
to
fd3c7d6
Compare
ans-ioki
reviewed
Dec 17, 2021
eikes
force-pushed
the
runtime-attribute-class-resolution
branch
5 times, most recently
from
4eaea3c
to
41189d2
Compare
eikes
force-pushed
the
runtime-attribute-class-resolution
branch
from
41189d2
to
ddb341c
Compare
|
Should I go ahead and merge this or are we waiting for someone or something? |
|
@eikes I did already leave for the holidays. You can merge your PRs if you have at least one approval. |
rmehner
added a commit
that referenced
this pull request
Jan 6, 2022
This was accidentally introduced in #54 and prevented us from creating rides, since they don't have a version then as they are just about to be created.
rmehner
added a commit
that referenced
this pull request
Jan 6, 2022
This was accidentally introduced in #54 and prevented us from creating rides, since they don't have a version then as they are just about to be created.
rmehner
added a commit
that referenced
this pull request
Jan 6, 2022
This was accidentally introduced in #54 and prevented us from creating rides, since they don't have a version then as they are just about to be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.