Fix version being required on create for rides #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally introduced in #54 and prevented us from creating rides, since they don't have a version then as they are just about to be created.
rmehner
force-pushed
the
fix-ride-version-being-wrongly-required-on-ride-creation
branch
from
fb1810a
to
3370323
Compare
|
What does the version field represent? |
|
The current version of the ride. It will be increased if any of the attributes change. This is important for conflict detection as every update needs to provide the version it tries to update or else it will fail. Also note that version had been defined already a couple of lines down and was accidentally defined again there, but with |
rmehner
deleted the
fix-ride-version-being-wrongly-required-on-ride-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally introduced in #54 and prevented us from creating
rides, since they don't have a version then as they are just about to be
created.
In the long run, we might wanna sort those attributes alphabetically, so that these kind of double definitions are easier to spot.