This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Remove syn-related API #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 19, 2021 10:27
o0Ignition0o
approved these changes
Jul 26, 2021
src/glue.rs
Outdated
| impl Error for InvalidRustcAst {} | ||
| fn get_diagnosis(tcx: &TyCtxt) -> AnyResult<ApiCompatibilityDiagnostics> { | ||
| let (prev, curr) = get_crates_id(tcx).context("Failed to get dependencies crate id")?; | ||
| let comparator = compare(tcx, prev, curr); |
src/glue.rs
Outdated
| Ok(comparator.run(tcx)) | ||
| } | ||
|
|
||
| pub fn get_crates_id(tcx: &TyCtxt) -> AnyResult<(CrateNum, CrateNum)> { |
There was a problem hiding this comment.
probably not the best name here 😅
src/glue.rs
Outdated
|
|
||
| let prev_api = PublicApi::from_ast(&prev_ast); | ||
| let curr_api = PublicApi::from_ast(&curr_ast); | ||
| pub fn compare(tcx: &TyCtxt, prev: CrateNum, curr: CrateNum) -> ApiComparator { |
o0Ignition0o
pushed a commit
that referenced
this pull request
Aug 16, 2021
* Pass a correct `RUSTC_WRAPPER` variable to cargo * Add diagnosis generation system for public items * Use rustc api everywhere * Don't emit warnings when compiling deps and glue * Emit less data on integration tests * Refactor the testing pipeline * Remove too-close-to-syn code * Completely remove syn from the project * Remove warnings * Remove now-useless trait_ attribute of DiagnosisItem * A few renamings
o0Ignition0o
pushed a commit
that referenced
this pull request
Aug 16, 2021
* Pass a correct `RUSTC_WRAPPER` variable to cargo * Add diagnosis generation system for public items * Use rustc api everywhere * Don't emit warnings when compiling deps and glue * Emit less data on integration tests * Refactor the testing pipeline * Remove too-close-to-syn code * Completely remove syn from the project * Remove warnings * Remove now-useless trait_ attribute of DiagnosisItem * A few renamings
scrabsha
pushed a commit
that referenced
this pull request
Sep 20, 2021
* Add homemade logo (#25) This logo was created by Morgane Gaillard and is provided under the MPL license. (clippy warnings have been fixed, too) * Remove syn-related API (#24) * Pass a correct `RUSTC_WRAPPER` variable to cargo * Add diagnosis generation system for public items * Use rustc api everywhere * Don't emit warnings when compiling deps and glue * Emit less data on integration tests * Refactor the testing pipeline * Remove too-close-to-syn code * Completely remove syn from the project * Remove warnings * Remove now-useless trait_ attribute of DiagnosisItem * A few renamings * Create the CompilerInvocationSettings structure * Make "read settings from disk" a 'Settings method * tmp * AnyResult<Foo> => AnyResult<Self> * use consts instead of raw and * wip, still not super happy with glue_gen and invocationsettings but we re getting there * still a lot of feature envy, we re passing previous and next crate everywhere, it requires me to get back to the drawing board again. the good news is it seems to work tho * still not there but it s getting better * still not super happy with temp_dir / glue_path conversions here and there but it s in a good enough shape to be iterated on imo * oopsie, a rebase leftover when fixing conflicts * wip * run a real compiler, please * TMP (2) * Make git tests pass again Co-authored-by: o0Ignition0o <jeremy.lempereur@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.