Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to select which columns to display #34

Merged
merged 5 commits into from
Nov 28, 2015

Conversation

antocuni
Copy link
Contributor

No description provided.

@ionelmc
Copy link
Owner

ionelmc commented Nov 26, 2015

Nice, thanks!

Something is going on with Travis, it did not start a build. Lemme see if I figure it out ...

@antocuni
Copy link
Contributor Author

good, now travis and appveyor have been triggered. Let's wait for the result :)

…med the first time we ask 'prop in columns', meaning that the second time is empty. I hate py3k
"* benchmark: 2 tests *",
"Name (time in ?s) * Max * Iterations * Min *",
"------*",
"test_fast * 1 *",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the calibration don't guarantee 1 iteration. Maybe just remove this line and following lies - you can only assert on the header part reliably.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS. This is what causes pypy jobs to fail on travis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thank you for the hint. Let's see if it finally passes now :)

…, which is the one which we actually care about :)
ionelmc added a commit that referenced this pull request Nov 28, 2015
Add an option to select which columns to display
@ionelmc ionelmc merged commit c9b08a3 into ionelmc:master Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants