Fix update hooks specs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, good catch! I wonder how did it even work previously and why this still shows up the merged commits from the netrc PR ... |
drebs
force-pushed
the
fix-update-machine-info-hook-spec
branch
from
e3c7719
to
9be023a
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 77.71% 77.71%
=======================================
Files 16 16
Lines 1696 1696
Branches 303 303
=======================================
Hits 1318 1318
Misses 316 316
Partials 62 62Continue to review full report at Codecov.
|
|
I rebased and now only the 3 new commits are shown. |
leap-code-o-matic
pushed a commit
to leapcode/soledad
that referenced
this pull request
Apr 20, 2017
There were some changes needed in pytest-benchmark so we could successfully use it for soledad benchmarks graphing: ionelmc/pytest-benchmark#73 ionelmc/pytest-benchmark#74 ionelmc/pytest-benchmark#75 The contributions were accepted but not released yet, so this commit uses the code from upstream git repository's master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook calls and the specs used different parameter names for
pytest_benchmark_update_machine_infoandpytest_benchmark_update_commit_info, and pytest complained and failed when trying to override those hooks.These commits fix the specs by changing the parameters names. Another approach would be to maintain the specs and change the hook calls, but it made more sense to change the parameter names in specs to maintain coherence with other hooks and with the parts of the code that call these hooks.
This pull request is made on top of #73, so that one should be merged first.