Add commit_info.author_time #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With git, there are different times recorded per commit, one `CommitDate` and `AuthorDate`. They can differ quite a lot when commits get rebased and merged from branches i.e. So we include both times. Mercurial doesn't differentiate in this afaik, which leads to an empty `commit_info.author_time`.
|
Now I wonder is this isn't better done in a hook, eg: http://pytest-benchmark.readthedocs.io/en/stable/hooks.html#pytest_benchmark.hookspec.pytest_benchmark_update_commit_info What do you need all this time info for anyway? |
|
We want to graph the benchmark grouped by commit, sorted by the commit/author time in the graph. |
leap-code-o-matic
pushed a commit
to leapcode/soledad
that referenced
this pull request
Apr 20, 2017
There were some changes needed in pytest-benchmark so we could successfully use it for soledad benchmarks graphing: ionelmc/pytest-benchmark#73 ionelmc/pytest-benchmark#74 ionelmc/pytest-benchmark#75 The contributions were accepted but not released yet, so this commit uses the code from upstream git repository's master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With git, there are different times recorded per commit, one
CommitDateandAuthorDate.They can differ quite a lot when commits get rebased and merged from
branches i.e. So we include both times.
Mercurial doesn't differentiate in this afaik, which leads to an
empty
commit_info.author_time.