Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No cordova.js added to index.html without "scripts" property in angular.json #179

Closed
maxtacco opened this issue Oct 18, 2019 · 2 comments · Fixed by #182
Closed

No cordova.js added to index.html without "scripts" property in angular.json #179

maxtacco opened this issue Oct 18, 2019 · 2 comments · Fixed by #182
Labels
released

Comments

@maxtacco
Copy link

maxtacco commented Oct 18, 2019 •
edited

Hi,
I just spent hours investigating why cordova.js wasn't included in the final index.html of my Ionic project. It looks like after updating to Angular 8 / Ionic toolkit 2.0.0 I have to add "scripts" property to angular.json's build section even if I don't have any additional scripts to configure.
This is really weird behavior and should be documented or a warning given at least. Better yet Ionic toolkit should be updated to add cordova.js without checking for "scripts" in options.
@mhartington
Copy link
Member

Hey there! Good catch. It looks like I wrote a check for scripts, but never handled a situation where scripts would be null. Should be an easy fix

mhartington added a commit that referenced this issue Oct 22, 2019
@mhartington
fix(utils): handle no scripts in angular
0aeec97 
Fixes #179
@mhartington mhartington mentioned this issue Oct 22, 2019
Merged
imhoffd pushed a commit that referenced this issue Oct 22, 2019
@mhartington @imhoffd
fix(build): handle no scripts in angular (#182)
388e1ad 
Fixes #179
Ionitron added a commit that referenced this issue Oct 22, 2019
@Ionitron
chore(release): 2.1.1 [skip ci]
4bea3a4 
## [2.1.1](v2.1.0...v2.1.1) (2019-10-22)

### Bug Fixes

* **build:** handle no scripts in angular ([#182](#182)) ([388e1ad](388e1ad)), closes [#179](#179)
@Ionitron
Copy link
Collaborator

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dirkgroenen dirkgroenen mentioned this issue Jan 8, 2020
Merged
wand1252 added a commit to wand1252/angular-toolkit-develop that referenced this issue Aug 31, 2022
@wand1252
chore(release): 2.1.1 [skip ci]
af39b87 
## [2.1.1](ionic-team/angular-toolkit@v2.1.0...v2.1.1) (2019-10-22)

### Bug Fixes

* **build:** handle no scripts in angular ([#182](ionic-team/angular-toolkit#182)) ([388e1ad](ionic-team/angular-toolkit@388e1ad)), closes [#179](ionic-team/angular-toolkit#179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(utils): handle no scripts in angular ionic-team/angular-toolkit
3 participants
@mhartington @Ionitron @maxtacco