fix(camera): Append change listener only once (#486)

ionic-team · Jun 17, 2021 · 5b7021e · 5b7021e
1 parent cdc1835
commit 5b7021e
Showing 1 changed file with 42 additions and 40 deletions.
diff --git a/camera/src/web.ts b/camera/src/web.ts
@@ -64,6 +64,48 @@ export class CameraWeb extends WebPlugin implements CameraPlugin {
       input.type = 'file';
       input.hidden = true;
       document.body.appendChild(input);
+      input.addEventListener('change', (_e: any) => {
+        const file = input.files![0];
+        let format = 'jpeg';
+
+        if (file.type === 'image/png') {
+          format = 'png';
+        } else if (file.type === 'image/gif') {
+          format = 'gif';
+        }
+
+        if (
+          options.resultType === 'dataUrl' ||
+          options.resultType === 'base64'
+        ) {
+          const reader = new FileReader();
+
+          reader.addEventListener('load', () => {
+            if (options.resultType === 'dataUrl') {
+              resolve({
+                dataUrl: reader.result,
+                format,
+              } as Photo);
+            } else if (options.resultType === 'base64') {
+              const b64 = (reader.result as string).split(',')[1];
+              resolve({
+                base64String: b64,
+                format,
+              } as Photo);
+            }
+
+            cleanup();
+          });
+
+          reader.readAsDataURL(file);
+        } else {
+          resolve({
+            webPath: URL.createObjectURL(file),
+            format: format,
+          });
+          cleanup();
+        }
+      });
     }
 
     input.accept = 'image/*';
@@ -80,46 +122,6 @@ export class CameraWeb extends WebPlugin implements CameraPlugin {
       (input as any).capture = 'environment';
     }
 
-    input.addEventListener('change', (_e: any) => {
-      const file = input.files![0];
-      let format = 'jpeg';
-
-      if (file.type === 'image/png') {
-        format = 'png';
-      } else if (file.type === 'image/gif') {
-        format = 'gif';
-      }
-
-      if (options.resultType === 'dataUrl' || options.resultType === 'base64') {
-        const reader = new FileReader();
-
-        reader.addEventListener('load', () => {
-          if (options.resultType === 'dataUrl') {
-            resolve({
-              dataUrl: reader.result,
-              format,
-            } as Photo);
-          } else if (options.resultType === 'base64') {
-            const b64 = (reader.result as string).split(',')[1];
-            resolve({
-              base64String: b64,
-              format,
-            } as Photo);
-          }
-
-          cleanup();
-        });
-
-        reader.readAsDataURL(file);
-      } else {
-        resolve({
-          webPath: URL.createObjectURL(file),
-          format: format,
-        });
-        cleanup();
-      }
-    });
-
     input.click();
   }