fix(filesystem): is not requesting permission on public directories (#…

…246)
ionic-team · Feb 12, 2021 · aa897ab · aa897ab
1 parent 957843b
commit aa897ab
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/FilesystemPlugin.java b/filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/FilesystemPlugin.java
@@ -52,7 +52,7 @@ public void readFile(PluginCall call) {
             return;
         }
 
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             try {
@@ -90,7 +90,7 @@ public void writeFile(PluginCall call) {
 
         String directory = getDirectoryParameter(call);
         if (directory != null) {
-            if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+            if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
                 requestAllPermissions(call, "permissionCallback");
             } else {
                 // create directory because it might not exist
@@ -182,7 +182,7 @@ public void appendFile(PluginCall call) {
     public void deleteFile(PluginCall call) {
         String file = call.getString("path");
         String directory = getDirectoryParameter(call);
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             try {
@@ -203,7 +203,7 @@ public void mkdir(PluginCall call) {
         String path = call.getString("path");
         String directory = getDirectoryParameter(call);
         boolean recursive = call.getBoolean("recursive", false).booleanValue();
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             try {
@@ -227,7 +227,7 @@ public void rmdir(PluginCall call) {
 
         File fileObject = implementation.getFileObject(path, directory);
 
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             if (!fileObject.exists()) {
@@ -260,7 +260,7 @@ public void readdir(PluginCall call) {
         String path = call.getString("path");
         String directory = getDirectoryParameter(call);
 
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             try {
@@ -285,7 +285,7 @@ public void getUri(PluginCall call) {
 
         File fileObject = implementation.getFileObject(path, directory);
 
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             JSObject data = new JSObject();
@@ -301,7 +301,7 @@ public void stat(PluginCall call) {
 
         File fileObject = implementation.getFileObject(path, directory);
 
-        if (!isPublicDirectory(directory) && !isStoragePermissionGranted()) {
+        if (isPublicDirectory(directory) && !isStoragePermissionGranted()) {
             requestAllPermissions(call, "permissionCallback");
         } else {
             if (!fileObject.exists()) {