Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyboard): add types for config files #115

Merged
merged 4 commits into from
Dec 7, 2020
Merged

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Nov 29, 2020

Add the keyboard config types for capacitor.config.ts files.

ref: ionic-team/capacitor@79334e4

@imhoffd imhoffd changed the title feat: plugin configuration types feat(keyboard): add types for config files Dec 5, 2020
@imhoffd imhoffd marked this pull request as ready for review December 5, 2020 00:34
@imhoffd imhoffd moved this from In progress 🤺 to Needs review 🤔 in Capacitor Engineering ⚡️ Dec 5, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments should mention the configurations are iOS only
https://capacitorjs.com/docs/apis/keyboard#keyboard-configuration-ios-only

@imhoffd imhoffd merged commit 09bba16 into main Dec 7, 2020
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Dec 7, 2020
@imhoffd imhoffd deleted the config-plugins-types branch December 7, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants