Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(device): Improving iOSVersion consistency #1514

Merged
merged 4 commits into from
Mar 31, 2023
Merged

fix(device): Improving iOSVersion consistency #1514

merged 4 commits into from
Mar 31, 2023

Conversation

theproducer
Copy link
Contributor

closes: #1510

markemer
markemer approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think most people will use the string version, but this will work for > < aficionados.

@theproducer theproducer merged commit b697fee into main Mar 31, 2023
@theproducer theproducer deleted the 5.x/device/ios-version branch March 31, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markemer markemer markemer approved these changes

@IT-MikeS IT-MikeS IT-MikeS approved these changes

@jcesarmobile jcesarmobile Awaiting requested review from jcesarmobile

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@giralte-ionic giralte-ionic Awaiting requested review from giralte-ionic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device plugin: iOSVersion is inconsistent for 16.0 vs. 16.0.1 vs. 16.0.10
3 participants
@theproducer @markemer @IT-MikeS