Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filesystem): rmdir doesn't resolve on iOS #239

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix(filesystem): rmdir doesn't resolve on iOS #239

merged 1 commit into from
Feb 5, 2021

Conversation

leo6104
Copy link
Contributor

@leo6104 leo6104 commented Feb 4, 2021 •
edited by jcesarmobile
Loading

closes #238

@leo6104 leo6104 changed the title never end when we call Filesystem.rmdir in iOS (issue #238) fix(Filesystem): Filesystme.rmdir finish correctly in iOS (call.resolve()) (issue #238) Feb 5, 2021
@leo6104 leo6104 mentioned this pull request Feb 5, 2021
Closed
@jcesarmobile jcesarmobile changed the title fix(Filesystem): Filesystme.rmdir finish correctly in iOS (call.resolve()) (issue #238) fix(filesystem): rmdir doesn't resolve on iOS Feb 5, 2021
jcesarmobile
jcesarmobile approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I was looking into another issue and noticed this, was going to fix it but saw your PR, good catch!

@jcesarmobile jcesarmobile merged commit 7ca538b into ionic-team:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filesystem.rmdir doesn't call resolve function when it success.
2 participants
@leo6104 @jcesarmobile