Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): browserFinished does not fire when closing popovers #483

Merged
merged 4 commits into from
Jun 17, 2021

Conversation

inbreaks
Copy link
Contributor

No description provided.

@jcesarmobile jcesarmobile changed the title fix(browser): SafariViewControllerDidFinish does not fire when swiping down to dismiss fix(browser): browserFinished does not fire when closing popovers Jun 17, 2021
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, I made a few small changes and one addition to also fire the event when closing the popover on iPads on iOS 12

@jcesarmobile jcesarmobile merged commit fb8dbb8 into ionic-team:main Jun 17, 2021
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Nov 9, 2022
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants