feat(android): support for minimizeApp #743
Conversation
app/ios/Plugin/AppPlugin.m
Outdated
| @@ -9,4 +9,5 @@ | |||
| CAP_PLUGIN_METHOD(getLaunchUrl, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(getState, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnNone); | |||
| CAP_PLUGIN_METHOD(minimizeApp, CAPPluginReturnNone); | |||
There was a problem hiding this comment.
The return type should be CAPPluginReturnPromise since in the types you said it returns Promise<void>;
app/src/definitions.ts
Outdated
| /** | ||
| * Minimizes application | ||
| */ | ||
| minimizeApp(): Promise<void>; |
There was a problem hiding this comment.
Can you move it up before all the listener related functions?
Also, can mention that the feature is only available for Android?
app/ios/Plugin/AppPlugin.m
Outdated
| @@ -9,4 +9,5 @@ | |||
| CAP_PLUGIN_METHOD(getLaunchUrl, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(getState, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnNone); | |||
| CAP_PLUGIN_METHOD(minimizeApp, CAPPluginReturnNone); | |||
There was a problem hiding this comment.
The return type should be CAPPluginReturnPromise since in the types you said it returns Promise<void>;
|
Thanks for review. Added changes. |
|
Not all comments are addressed, and you have removed a few android test classes, can you address the missing comments and put those classes back? |
|
Hm. Looks like fmt script removed classes. I will address all comments. I'm sorry that I missed these things |
|
did some minor changes on texts, but other than that looks good, thanks! |
I think it makes sense if this small feature will be part of app plugin.
closes #130