Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android, implement deviceInfo.Name property #86

Closed
DaanWasscher opened this issue Nov 2, 2020 · 2 comments · Fixed by #88
Closed

feat: Android, implement deviceInfo.Name property #86

DaanWasscher opened this issue Nov 2, 2020 · 2 comments · Fixed by #88
Labels
enhancement New feature or request platform: android

Comments

@DaanWasscher
Copy link
Contributor

Feature Request

Description

For iOS the name property on device info is already implemented. See ionic-team/capacitor#2130
But for Android the implementation is missing.

Platform(s)

Android

Preferred Solution

Added in api level 25 there is a way to easily get the device name.
https://developer.android.com/reference/android/provider/Settings.Global#DEVICE_NAME

If on api 25+ then return the device name. Otherwise return null.

If wanted, I could create a PR with the preferred solution in this repo for the next 2.x capacitor version and a separate PR for the 3.x capacitor version in the plugins repo.

@jcesarmobile jcesarmobile transferred this issue from ionic-team/capacitor Nov 2, 2020
@jcesarmobile
Copy link
Member

we are not adding new features in 2.x branch, you can send the PR in this repo for the new @capacitor/device plugin

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 30, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request platform: android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants