Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deviceInfo.name implementation for Android #88

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Add deviceInfo.name implementation for Android #88

merged 6 commits into from
Nov 2, 2020

Conversation

DaanWasscher
Copy link
Contributor

Fixes #86

carlpoole
carlpoole reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@carlpoole carlpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would suggest adding the version info with Android since it won't work for all versions.

device/README.md Outdated Show resolved Hide resolved
device/src/definitions.ts Outdated Show resolved Hide resolved
DaanWasscher and others added 2 commits November 2, 2020 20:28
@DaanWasscher @carlpoole
Update device/README.md
13682f5 
Add minimum supported android version

Co-authored-by: Carl Poole <mail@carlpoole.com>
@DaanWasscher @carlpoole
Update device/src/definitions.ts
69156de 
Add minimum supported android version

Co-authored-by: Carl Poole <mail@carlpoole.com>
@imhoffd
Copy link
Contributor

imhoffd commented Nov 2, 2020

@DaanWasscher Can you run npm run build and commit the whitespace changes to the readme?

@imhoffd
Copy link
Contributor

imhoffd commented Nov 2, 2020

Thanks @DaanWasscher! This will make it in to the Device plugin before the launch of Capacitor 3.0. 💙

@imhoffd imhoffd merged commit bdc3b38 into ionic-team:main Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpoole carlpoole carlpoole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Android, implement deviceInfo.Name property
3 participants
@DaanWasscher @imhoffd @carlpoole