Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geolocation #13

Merged
merged 102 commits into from Dec 16, 2020
Merged

Geolocation #13

merged 102 commits into from Dec 16, 2020

Conversation

carlpoole
Copy link
Member

@carlpoole carlpoole commented Aug 13, 2020 •
edited

  • Android
  • iOS

@carlpoole carlpoole mentioned this pull request Aug 13, 2020
Closed
@imhoffd imhoffd added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Aug 21, 2020
carlpoole and others added 20 commits August 24, 2020 10:31
@carlpoole
Merge branch 'main' into geolocation
08ecc4d
@carlpoole
moved more geolocation out and testing
909119c
@carlpoole
manifest update, temp util
47747c7
@carlpoole
Merge branch 'main' into geolocation
f384018
@carlpoole
Use of the interface method for defining Geolocation Prompt behavior
6e46ec7
@carlpoole
cleanup interface
22782d3
@carlpoole
changed interface method name
89252c4
@carlpoole
Merge branch 'main' into geolocation
b64019d
@carlpoole
package updates
5d52c5a
@carlpoole
New annotation, removed unused method
b97d556
@carlpoole
Merged in main
ac54cc7
@carlpoole
Updated to work with new permissions changes WIP, some cleanup
228b6ce
@carlpoole
Merge branch 'main' into geolocation
792d5ae
@carlpoole
Merge branch 'main' into geolocation
8f88773
@carlpoole
Implementing permissions on geolocation
b9af8fb
@carlpoole
Comment stuff, cleanup
459bcc3
@carlpoole
IOS Geolocation initial breakout
43afd48
@carlpoole
More ios work
a49fbb0
@jcesarmobile
chore: replace UnsupportedBrowserException with unavailable
00c4398
@jcesarmobile
Merge branch 'main' into unavailable
b6e231a
jcesarmobile
jcesarmobile requested changes Dec 14, 2020
View reviewed changes
geolocation/package.json Outdated Show resolved Hide resolved
geolocation/package.json Outdated Show resolved Hide resolved
geolocation/package.json Outdated Show resolved Hide resolved
geolocation/src/web.ts Outdated Show resolved Hide resolved
geolocation/src/web.ts Outdated Show resolved Hide resolved
Capacitor Engineering ⚡️ automation moved this from In progress 🤺 to Needs review 🤔 Dec 14, 2020
@jcesarmobile
Copy link
Member

There was an issue reported on capacitor repo about getLocation method on iOS returning error while being prompted for the permission. It was fixed in this PR and released on 2.4.3.
That or similar code should also be added here or the bug will be reintroduced.

@imhoffd imhoffd merged commit 911ae71 into main Dec 16, 2020
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Dec 16, 2020
@imhoffd imhoffd deleted the geolocation branch December 16, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

@ikeith ikeith ikeith approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlpoole @jcesarmobile @imhoffd @ikeith