Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pushnotifications): App Foreground -> Notification not-clickable #1324

Closed

Conversation

schmop
Copy link

@schmop schmop commented Dec 10, 2022

Problem:

When the app is in the foreground, or even active in the background, received push notifications are not clickable at the moment.

Cause:

I debugged it to be a problem in the fireNotification method. When creating a local copy of the remote notification (which only happens, if the app is running in back- or foreground), the newly created notification is created without Intend.
I am no android developer, excuse me, if I am not firm in the lingo.

Solution

The proposed changes introduce an intend to the local notification that

  • opens the app
  • sends the notification data
  • dismisses the notification as read.

@schmop
Copy link
Author

schmop commented Dec 10, 2022

References #1248

@marcelbloch
Copy link

seems to fix the issue

@brilliantinsane
Copy link

Will this ever be merged?

@junekpavel
Copy link

Thanks a lot for saving my day, applied this via patch-package and it works like a charm.

@AntoscencoVladimir
Copy link

Same here ...

@trinitiwowka
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants