fix(android): Migrate plugins from Color.parseColor() to WebColor.parseColor() #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think only the colors that come from the web part should use the new Or in case we want all colors to be |
jcesarmobile
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
looks good
you should probably add a note about it on the upgrade guide
ionic-team/capacitor#3320
|
Yeah I'm planning on it 👍 |
hmaretic24
pushed a commit
to hmaretic24/capacitor-plugins
that referenced
this pull request
Nov 9, 2022
hmaretic24
added a commit
to hmaretic24/capacitor-plugins
that referenced
this pull request
Apr 25, 2023
…ionic-team#140) # Conflicts: # android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ionic-team/capacitor#3947
Change all Color.parseColor() to WebColor.parseColor() to make sure that Colors from web to Android are correctly parsed. Android format is #AARRGGBB and Web Format is #RRGGBBAA