fix(google-maps): Added null check to addMarkers method #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AE1NS
force-pushed
the
addmarkers-null-check
branch
3 times, most recently
from
f10c4f3
to
71eb6c7
Compare
AE1NS
force-pushed
the
addmarkers-null-check
branch
from
71eb6c7
to
364d95a
Compare
jcesarmobile
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a null check to the addMarkers method for Android.
googleMapin line 183 can be null here, when the map is destroyed but the method is still processing. ThengoogleMapMarkeris also null which crashs in line 191.Closes #1570