Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser #16

Merged
merged 58 commits into from Oct 14, 2020
Merged

Browser #16

merged 58 commits into from Oct 14, 2020

Conversation

ikeith
Copy link
Contributor

@ikeith ikeith commented Aug 18, 2020 •
edited

@ikeith ikeith mentioned this pull request Aug 18, 2020
Closed
@imhoffd imhoffd added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Aug 21, 2020
@ikeith ikeith marked this pull request as ready for review August 28, 2020 19:24
imhoffd
imhoffd reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@imhoffd imhoffd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you copy in the following files from a plugin in main? There have been changes:

  • .gitignore
  • .eslintignore

ESLint should be set up in this plugin.

Please remove the Podfile.lock and package-lock.json from git for this plugin, we're ignoring them now

@jcesarmobile
Copy link
Member

Also missing the README.md and LICENSE files

jcesarmobile
jcesarmobile requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

browser/android/src/main/java/com/capacitorjs/plugins/browser/Browser.java Outdated Show resolved Hide resolved
browser/android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java Outdated Show resolved Hide resolved
browser/android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java Outdated Show resolved Hide resolved
browser/android/src/main/java/com/capacitorjs/plugins/browser/Browser.java Outdated Show resolved Hide resolved
browser/ios/Plugin/BrowserPlugin.m Outdated Show resolved Hide resolved
browser/ios/Plugin/BrowserPlugin.swift Show resolved Hide resolved
browser/package.json Show resolved Hide resolved
browser/package.json Outdated Show resolved Hide resolved
ikeith and others added 8 commits September 29, 2020 11:27
@ikeith @jcesarmobile
Update browser/android/src/main/java/com/capacitorjs/plugins/browser/…
fea57e2 
…Browser.java

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith @jcesarmobile
Update browser/android/src/main/java/com/capacitorjs/plugins/browser/…
7de9976 
…BrowserPlugin.java

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith @jcesarmobile
Update browser/android/src/main/java/com/capacitorjs/plugins/browser/…
d97036d 
…BrowserPlugin.java

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith @jcesarmobile
Update browser/android/src/main/java/com/capacitorjs/plugins/browser/…
5c2fdbb 
…Browser.java

Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith @jcesarmobile
Update browser/ios/Plugin/BrowserPlugin.m
185cbd6 
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith @jcesarmobile
Update browser/package.json
f65d24c 
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith @jcesarmobile
Update browser/package.json
e2bd8c1 
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@ikeith
Merge branch 'main' into browser
6d8be2b
@imhoffd imhoffd merged commit 6ad5597 into main Oct 14, 2020
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Oct 14, 2020
@imhoffd imhoffd deleted the browser branch October 14, 2020 21:23
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Nov 9, 2022
@ikeith
feat: Browser plugin (ionic-team#16)
016b696
hmaretic24 added a commit to hmaretic24/capacitor-plugins that referenced this pull request Apr 25, 2023
@hmaretic24
feat: Browser plugin (ionic-team#16)
627e919 
# Conflicts:
#	.gitignore
#	README.md
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@carlpoole carlpoole carlpoole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikeith @jcesarmobile @imhoffd @carlpoole