Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make toggle-local work on windows #1612

Merged
merged 2 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Sometimes, it may be necessary to work on Capacitor in parellel with the plugin(
5. Toggle each plugin to use your local copy of Capacitor.

```shell
npm install
npm run toggle-local
```

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"@actions/core": "^1.9.1",
"@ionic/prettier-config": "^1.0.1",
"@types/prompts": "^2.0.8",
"cross-spawn": "^7.0.3",
"esm": "^3.2.25",
"lerna": "^3.22.1",
"prettier": "~2.3.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/lib/subprocess.mjs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as cp from 'child_process';
import * as util from 'util';
import spawn from 'cross-spawn';

export const exec = util.promisify(cp.exec);
export const spawn = cp.spawn;
export const run = (cmd, args, options) => wait(spawn(cmd, args, options));
export const wait = async p => {
return new Promise((resolve, reject) => {
Expand Down
Loading