Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(camera): do not require unnecessary permissions for Camera plugin #1702

Closed
wants to merge 2 commits into from
Closed

fix(camera): do not require unnecessary permissions for Camera plugin #1702

wants to merge 2 commits into from

Conversation

RB-Hippo
Copy link

@RB-Hippo RB-Hippo commented Jul 25, 2023 •
edited
Loading

Fixes #1701.

This PR makes the Camera plugins only require the necessary permisisons:

<uses-permission android:name="android.permission.READ_MEDIA_IMAGES"/>
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="29"/>

Tested on Android 9, 10, 11, 12 and 13.

@RB-Hippo RB-Hippo changed the title Do not require unnecessary permissions for Camera plugin fix(camera): do not require unnecessary permissions for Camera plugin Jul 25, 2023
@RB-Hippo RB-Hippo mentioned this pull request Jul 25, 2023
Closed
@RB-Hippo RB-Hippo force-pushed the camera-permissions branch 2 times, most recently from 11b764a to ab5f428 Compare July 28, 2023 13:04
@dallastjames dallastjames added the type: feature request A new feature, enhancement, or improvement label Jul 28, 2023
@jcesarmobile
Copy link
Member

thanks for the PR, but the way it's implemented it would be breaking as it removes the photos alias that users could be using

I've sent #1713 to address the issue in a non breaking way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature request A new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated WRITE_EXTERNAL_STORAGE permission required for Camera
3 participants
@RB-Hippo @jcesarmobile @dallastjames