Filesystem #19
Merged
Filesystem #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
force-pushed
the
filesystem
branch
from
fd64367
to
c81f352
Compare
carlpoole
reviewed
Sep 4, 2020
carlpoole
reviewed
Sep 4, 2020
filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/Filesystem.java
Show resolved
Hide resolved
carlpoole
reviewed
Sep 4, 2020
filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/Filesystem.java
Show resolved
Hide resolved
imhoffd
reviewed
Nov 18, 2020
filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/FilesystemPlugin.java
Outdated
Show resolved
Hide resolved
imhoffd
reviewed
Nov 19, 2020
carlpoole
reviewed
Nov 19, 2020
filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/FilesystemPlugin.java
Outdated
Show resolved
Hide resolved
carlpoole
reviewed
Nov 19, 2020
filesystem/android/src/main/java/com/capacitorjs/plugins/filesystem/FilesystemPlugin.java
Outdated
Show resolved
Hide resolved
|
I’m aware of pending changes, you don’t need to remind them, but I’m not going to push them until we have a new alpha release. In fact I’ve made most of them on my local branch but didn’t push them because things keep changing again and again. |
imhoffd
reviewed
Dec 2, 2020
ikeith
approved these changes
Dec 3, 2020
carlpoole
approved these changes
Dec 3, 2020
imhoffd
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see ionic-team/capacitor#3458 and ionic-team/capacitor-testapp#10