fix(screen-orientation): Add OrientationLockType #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al of OrientationLockType
jcesarmobile
changed the title
dtarnawsky
changed the title
dallastjames
added
the
pr review requested
giralte-ionic
requested review from
jcesarmobile,
theproducer,
ItsChaceD and
IT-MikeS
jcesarmobile
requested changes
Dec 13, 2023
There was a problem hiding this comment.
just a minor comment about the noe
I prefer this approach over #1929 as that seems very complex and harder to maintain.
I tested this approach and didn't seem to generate conflicts in apps using typescript < 5.2.
I released a dev build of screen-orientation with dev version: 6.0.0-dev-1915-20231122T130858.0 with this change
|
For anyone depending on this in Capacitor 5.x, a solution to this is to add a definitions.d.ts file in your src directory, and add: |
jcesarmobile
approved these changes
Dec 18, 2023
giralte-ionic
approved these changes
Dec 18, 2023
IT-MikeS
pushed a commit
that referenced
this pull request
Jan 23, 2024
Co-authored-by: Dan Giralté <97970732+giralte-ionic@users.noreply.github.com> Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript > v5.2 removes
OrientationLockType. This adds the type back in.See (microsoft/TypeScript-DOM-lib-generator#1615).
Fixes WN-1457.