Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add apple privacy manifest code requirements #2076

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

ItsChaceD
Copy link
Contributor

This PR adds the Apple Privacy Manifest Requirements to the relevant plugins.

Addresses #2060

@Ionitron Ionitron added this to In progress 🤺 in Capacitor Engineering ⚡️ Apr 10, 2024
device/README.md Outdated Show resolved Hide resolved
device/README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 10, 2024

Released dev build of filesystem with dev version: 6.0.0-dev-2076-20240415T161401.0

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Privacy Manifest page now on the docs that could be linked instead of adding the Manual Steps about how to do it on each plugin README

https://capacitorjs.com/docs/ios/privacy-manifest

I think the text should be more clear about which keys each plugin requires, the example file is ok, but people can think it's an example and not what they need to add.

Also would be good to link each key to the specific key docs as the vs code extensio does
https://github.com/ionic-team/vscode-ionic/blob/fd14fafce9aba7fe0da853d0b6eeccf27b10fda1/src/xcode.ts#L278-L288

filesystem/README.md Outdated Show resolved Hide resolved
preferences/README.md Outdated Show resolved Hide resolved
@ItsChaceD ItsChaceD merged commit 8d57539 into main Apr 15, 2024
22 checks passed
Capacitor Engineering ⚡️ automation moved this from In progress 🤺 to Done 🎉 Apr 15, 2024
@ItsChaceD ItsChaceD deleted the docs/apple-privacy-codes branch April 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants