Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Notifications #94

Merged
merged 78 commits into from
Jan 13, 2021
Merged

Local Notifications #94

merged 78 commits into from
Jan 13, 2021

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Nov 10, 2020 •
edited by theproducer
Loading

TODO:

  • Add shared UNUserNotificationCenterDelegate to Capacitor core
  • Fix requestPermissions on Android
  • Documentation
  • rename events
  • definitions.ts channel method updates (SDK 26+)

testapp PR: ionic-team/capacitor-testapp#53

@imhoffd imhoffd mentioned this pull request Nov 10, 2020
Closed
@imhoffd imhoffd added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Nov 10, 2020
imhoffd and others added 17 commits November 20, 2020 11:39
@imhoffd
wip
b41425b
@imhoffd
Merge branch 'main' into local-notifications
3fbadd5
@imhoffd
wip
c28508b
@carlpoole
updated handleOnActivityResult for alpha 7
164c774
@carlpoole
put back null check
48eb016
@imhoffd
toggle-local
0c9f009
@adamdbradley
refactor: update plugin registration from runtime refactor (#93)
fbd0887
@imhoffd
Merge branch 'alpha.7' into local-notifications
14c62e3
@imhoffd
registerPlugin
eb92b74
@imhoffd
use new permission annotation
3833819
@imhoffd
Merge branch 'update-permission-annotations' into local-notifications
28d0679
@imhoffd
Merge remote-tracking branch 'origin/share-result' into local-notific…
ae1219d 
…ations
@imhoffd
refactor(android): use new permission annotation (#113)
ac7478a
@carlpoole
refactor(android): updated share plugin handleOnActivityResult signat…
84c4403 
…ure (#111)
@imhoffd
Merge branch 'alpha.7' into local-notifications
641cf52
@imhoffd
java permission updates
de8e45e
@imhoffd
ios delegate updates
9375aa7
@imhoffd imhoffd moved this from In progress 🤺 to Needs review 🤔 in Capacitor Engineering ⚡️ Dec 28, 2020
@theproducer theproducer self-assigned this Jan 8, 2021
@imhoffd
Copy link
Contributor Author

imhoffd commented Jan 13, 2021

LGTM

@imhoffd imhoffd merged commit e59ba9c into main Jan 13, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Jan 13, 2021
@imhoffd imhoffd deleted the local-notifications branch January 13, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeith ikeith ikeith approved these changes

@carlpoole carlpoole carlpoole approved these changes

@thomasvidas thomasvidas thomasvidas approved these changes

@jcesarmobile jcesarmobile Awaiting requested review from jcesarmobile

Assignees

@theproducer theproducer

Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@imhoffd @jcesarmobile @ikeith @carlpoole @thomasvidas @theproducer @adamdbradley