fix(cli): Don't add google-services plugin if missing (#5825)

ionic-team · Aug 4, 2022 · 48ff9e6 · 48ff9e6
1 parent 66954ef
commit 48ff9e6
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/cli/src/tasks/migrate.ts b/cli/src/tasks/migrate.ts
@@ -460,7 +460,7 @@ async function updateBuildGradle(
 ) {
   // In build.gradle add dependencies:
   // classpath 'com.android.tools.build:gradle:7.2.1'
-  // classpath 'com.google.gms:google-services:4.3.10'
+  // classpath 'com.google.gms:google-services:4.3.13'
   const txt = readFile(filename);
   if (!txt) {
     return;
@@ -474,13 +474,7 @@ async function updateBuildGradle(
   let replaced = txt;
 
   for (const dep of Object.keys(neededDeps)) {
-    if (!replaced.includes(`classpath '${dep}`)) {
-      replaced = txt.replace(
-        'dependencies {',
-        `dependencies {\n        classpath '${dep}:${neededDeps[dep]}'`,
-      );
-    } else {
-      // Update
+    if (replaced.includes(`classpath '${dep}`)) {
       replaced = setAllStringIn(
         replaced,
         `classpath '${dep}:`,