fix(cli): Fix cordova plugin config checker over checking on 4.x (#6443)

ionic-team · Mar 30, 2023 · 5ce68bb · 5ce68bb
1 parent 6f8d1ad
commit 5ce68bb
Showing 1 changed file with 19 additions and 12 deletions.
diff --git a/cli/src/cordova.ts b/cli/src/cordova.ts
@@ -954,19 +954,26 @@ export async function writeCordovaAndroidManifest(
                           }
                         }
                       } else {
-                        let foundRequiredElement = false;
-                        for (const existingElementItem of existingElement.children) {
-                          const foundRequiredElementIn = doesElementMatch(
-                            requiredElement,
-                            existingElementItem,
-                          );
-                          if (foundRequiredElementIn) {
-                            foundRequiredElement = true;
-                            break;
+                        if (
+                          requiredElement.children === undefined &&
+                          existingElement.children === undefined
+                        ) {
+                          return true;
+                        } else {
+                          let foundRequiredElement = false;
+                          for (const existingElementItem of existingElement.children) {
+                            const foundRequiredElementIn = doesElementMatch(
+                              requiredElement,
+                              existingElementItem,
+                            );
+                            if (foundRequiredElementIn) {
+                              foundRequiredElement = true;
+                              break;
+                            }
+                          }
+                          if (!foundRequiredElement) {
+                            return false;
                           }
-                        }
-                        if (!foundRequiredElement) {
-                          return false;
                         }
                       }
                     }