Skip to content

Commit

Permalink
fix(cli): also generate packageClassList on copy (#7358)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcesarmobile committed Mar 19, 2024
1 parent 7113a19 commit 865cceb
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
15 changes: 1 addition & 14 deletions cli/src/ios/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@ import {
import type { Plugin } from '../plugin';
import { copy as copyTask } from '../tasks/copy';
import { convertToUnixPath } from '../util/fs';
import {
getPluginFiles,
findPluginClasses,
writePluginJSON,
} from '../util/iosplugin';
import { generateIOSPackageJSON } from '../util/iosplugin';
import { resolveNode } from '../util/node';
import { checkPackageManager, generatePackageFile } from '../util/spm';
import { runCommand, isInstalled } from '../util/subprocess';
Expand Down Expand Up @@ -180,15 +176,6 @@ end`,
}
}

async function generateIOSPackageJSON(
config: Config,
plugins: Plugin[],
): Promise<void> {
const fileList = await getPluginFiles(plugins);
const classList = await findPluginClasses(fileList);
writePluginJSON(config, classList);
}

async function getRelativeCapacitoriOSPath(config: Config) {
const capacitoriOSPath = resolveNode(
config.app.rootDir,
Expand Down
4 changes: 4 additions & 0 deletions cli/src/tasks/copy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ import {
} from '../cordova';
import type { Config } from '../definitions';
import { isFatal } from '../errors';
import { getIOSPlugins } from '../ios/common';
import { logger } from '../log';
import { getPlugins } from '../plugin';
import { generateIOSPackageJSON } from '../util/iosplugin';
import { allSerial } from '../util/promise';
import { copyWeb } from '../web/copy';

Expand Down Expand Up @@ -135,6 +137,8 @@ export async function copy(
await copyCapacitorConfig(config, config.ios.nativeTargetDirAbs);
const cordovaPlugins = await getCordovaPlugins(config, platformName);
await handleCordovaPluginsJS(cordovaPlugins, config, platformName);
const iosPlugins = await getIOSPlugins(allPlugins);
await generateIOSPackageJSON(config, iosPlugins);
} else if (platformName === config.android.name) {
if (usesFederatedCapacitor) {
await copyFederatedWebDirs(config, config.android.webDirAbs);
Expand Down
9 changes: 9 additions & 0 deletions cli/src/util/iosplugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,12 @@ export async function writePluginJSON(
capJSON['packageClassList'] = classList;
writeJSONSync(capJSONFile, capJSON, { spaces: '\t' });
}

export async function generateIOSPackageJSON(
config: Config,
plugins: Plugin[],
): Promise<void> {
const fileList = await getPluginFiles(plugins);
const classList = await findPluginClasses(fileList);
writePluginJSON(config, classList);
}

0 comments on commit 865cceb

Please sign in to comment.