fix(cli): create-react-app framework detection should not look for re…

…act-dev-utils (#4585)
ionic-team · May 18, 2021 · 9f7910e · 9f7910e
1 parent d7f06be
commit 9f7910e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/cli/src/framework-configs.ts b/cli/src/framework-configs.ts
@@ -12,7 +12,6 @@ const FRAMEWORK_CONFIGS: FrameworkConfig[] = [
     name: 'Create React App',
     isMatch: config =>
       hasDependency(config, 'react-scripts') &&
-      hasDependency(config, 'react-dev-utils') &&
       !hasDependency(config, '@ionic/react'),
     webDir: 'build',
   },

diff --git a/cli/test/framework-detection.spec.ts b/cli/test/framework-detection.spec.ts
@@ -39,9 +39,8 @@ describe('framework detection', () => {
     expect(f?.webDir).toBe('dist');
   });
 
-  it('Create React App', () => {
+  it.only('Create React App', () => {
     addDep(config, 'react-scripts');
-    addDep(config, 'react-dev-utils');
     const f = detectFramework(config);
     expect(f?.name).toBe('Create React App');
     expect(f?.webDir).toBe('build');