Skip to content

Commit

Permalink
fix(cli): Migrate more plugin variables (#6552)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcesarmobile committed May 2, 2023
1 parent d3aacde commit b7da5b9
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions cli/src/tasks/migrate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,11 @@ export async function migrateCommand(
androidxMaterialVersion: '1.8.0',
androidxExifInterfaceVersion: '1.3.6',
androidxCoreKTXVersion: '1.10.0',
googleMapsPlayServicesVersion: '18.1.0',
googleMapsUtilsVersion: '3.4.0',
googleMapsKtxVersion: '3.4.0',
googleMapsUtilsKtxVersion: '3.4.0',
kotlinxCoroutinesVersion: '1.6.4',
};
for (const variable of Object.keys(pluginVariables)) {
await updateFile(
Expand Down Expand Up @@ -398,16 +403,22 @@ async function installLatestLibs(
}

async function writeBreakingChanges() {
const breaking = ['@capacitor/device'];
const breaking = [
'@capacitor/camera',
'@capacitor/device',
'@capacitor/local-notifications',
'@capacitor/push-notifications',
];
const broken = [];
for (const lib of breaking) {
if (allDependencies[lib]) {
broken.push(lib);
}
}
// TODO - remove "next" from the url once capacitor 5 is final
if (broken.length > 0) {
logger.info(
`IMPORTANT: Review https://capacitorjs.com/docs/updating/5-0#plugins for breaking changes in these plugins that you use: ${broken.join(
`IMPORTANT: Review https://capacitorjs.com/docs/next/updating/5-0#plugins for breaking changes in these plugins that you use: ${broken.join(
', ',
)}.`,
);
Expand Down

0 comments on commit b7da5b9

Please sign in to comment.