fix(cli): Support of BoM dependencies on cordova plugins (#5827)

ionic-team · Aug 15, 2022 · ea2d95b · ea2d95b
1 parent 7ce6dd4
commit ea2d95b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/cli/src/android/update.ts b/cli/src/android/update.ts
@@ -239,7 +239,11 @@ project(':${getGradlePackageName(
           `apply from: "${relativePluginPath}/${framework.$.src}"`,
         );
       } else if (!framework.$.type && !framework.$.custom) {
-        frameworksArray.push(`    implementation "${framework.$.src}"`);
+        if (framework.$.src.startsWith('platform(')) {
+          frameworksArray.push(`    implementation ${framework.$.src}`);
+        } else {
+          frameworksArray.push(`    implementation "${framework.$.src}"`);
+        }
       }
     });
     prefsArray = prefsArray.concat(getAllElements(p, platform, 'preference'));
@@ -324,7 +328,11 @@ export async function handleCordovaPluginsGradle(
   });
   let frameworkString = frameworksArray
     .map(f => {
-      return `    implementation "${f}"`;
+      if (f.startsWith('platform(')) {
+        return `    implementation ${f}`;
+      } else {
+        return `    implementation "${f}"`;
+      }
     })
     .join('\n');
   frameworkString = await replaceFrameworkVariables(