chore(android): remove unused launch_splash.xml #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is no longer used. Instead, configure the splash screen image with the `androidSplashResourceName` configuration option.
jcesarmobile
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Looks good.
Also people tend to think the launch_splash.xml is used and the android:scaleType="centerCrop" confuses them into thinking the image uses centerCrop, but even if they change the styles to use
launch_splash.xml, the android:scaleType="centerCrop" doesn't work on bitmaps, it's for ImageViews
7 tasks
|
@jcesarmobile @dwieeb by the way setting this in style xml file also sets this image as background for native modals on android. Is it possible to scope it just to splash screen? |
priyankpat
pushed a commit
to priyankpat/capacitor
that referenced
this pull request
Feb 13, 2020
chrisweight
added a commit
to chrisweight/capacitor
that referenced
this pull request
Feb 17, 2020
* upstream/master: (50 commits) feat(Device): Add getBatteryInfo function (ionic-team#2435) fix(doctor): add electron checks (ionic-team#2434) chore(android): target SDK version 29 (ionic-team#2433) feat(android): update gradle and dependencies (ionic-team#2431) fix(ios): Make Clipboard plugin return errors (ionic-team#2430) feat(android): Handle onDestroy lifecycle event in plugins (ionic-team#2421) docs(ce-plugins): Remove or replace deprecated plugins (ionic-team#2419) feat(ios): change native location accuracy values (ionic-team#2420) docs(ce-guides): Remove dead link (ionic-team#2418) docs(network): Remove example guide because of dead link (ionic-team#2417) feat(electron): Remove injectCapacitor function (ionic-team#2415) fix(android): plugin retained events not being retained if listeners were empty (ionic-team#2408) chore(android): remove unused launch_splash.xml (ionic-team#2411) feat(Filesystem): Remove createIntermediateDirectories from MkdirOptions (ionic-team#2410) feat(android): use Fused Location Provider on Geolocation plugin (ionic-team#2409) fix(toast): unify duration across platforms (ionic-team#2340) feat(PushNotifications): Make register method return if permission was granted (ionic-team#2324) chore(circleci): update Xcode and remove install-cocoapods job (ionic-team#2402) chore(cli): fix tests for newer node versions (ionic-team#2403) fix(android): return original camera image if edition was canceled (ionic-team#2358) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is no longer used. Instead, configure the splash screen image with the
androidSplashResourceNameconfiguration option.