Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(network): Remove example guide because of dead link #2417

Merged
merged 1 commit into from Feb 7, 2020
Merged

docs(network): Remove example guide because of dead link #2417

merged 1 commit into from Feb 7, 2020

Conversation

antoninbeaufort
Copy link
Contributor

Hi,

While reading the documentation, I found a deadlink, and this article no longer exists.

@jcesarmobile jcesarmobile changed the title [Docs] Remove dead link in example guide docs(ce-guides): Remove dead link Feb 7, 2020
@jcesarmobile jcesarmobile changed the title docs(ce-guides): Remove dead link docs(network): Remove example guide because of dead link Feb 7, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile merged commit 2364505 into ionic-team:master Feb 7, 2020
@antoninbeaufort antoninbeaufort deleted the patch-1 branch February 7, 2020 12:21
priyankpat pushed a commit to priyankpat/capacitor that referenced this pull request Feb 13, 2020
chrisweight added a commit to chrisweight/capacitor that referenced this pull request Feb 17, 2020
* upstream/master: (50 commits)
  feat(Device): Add getBatteryInfo function (ionic-team#2435)
  fix(doctor): add electron checks (ionic-team#2434)
  chore(android): target SDK version 29 (ionic-team#2433)
  feat(android): update gradle and dependencies (ionic-team#2431)
  fix(ios): Make Clipboard plugin return errors (ionic-team#2430)
  feat(android): Handle onDestroy lifecycle event in plugins (ionic-team#2421)
  docs(ce-plugins): Remove or replace deprecated plugins (ionic-team#2419)
  feat(ios): change native location accuracy values (ionic-team#2420)
  docs(ce-guides): Remove dead link (ionic-team#2418)
  docs(network): Remove example guide because of dead link (ionic-team#2417)
  feat(electron): Remove injectCapacitor function (ionic-team#2415)
  fix(android): plugin retained events not being retained if listeners were empty (ionic-team#2408)
  chore(android): remove unused launch_splash.xml (ionic-team#2411)
  feat(Filesystem): Remove createIntermediateDirectories from MkdirOptions (ionic-team#2410)
  feat(android): use Fused Location Provider on Geolocation plugin (ionic-team#2409)
  fix(toast): unify duration across platforms (ionic-team#2340)
  feat(PushNotifications): Make register method return if permission was granted (ionic-team#2324)
  chore(circleci): update Xcode and remove install-cocoapods job (ionic-team#2402)
  chore(cli): fix tests for newer node versions (ionic-team#2403)
  fix(android): return original camera image if edition was canceled (ionic-team#2358)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants